-
Notifications
You must be signed in to change notification settings - Fork 404
feat(multitenancy): Allow to watch ExternalSecrets in specific namespaces #548
feat(multitenancy): Allow to watch ExternalSecrets in specific namespaces #548
Conversation
c365639
to
d507005
Compare
d507005
to
1cae761
Compare
No Idea why the E2E tests are failing :-/ |
Thanks for the PRs! Will probably be abit before I can take a deeper look, hopefully someone else can take a peek as well! :) |
@Flydiverny That's a good point. I will add it to the readme file. However, I think that's shouldn't be done automatically (i.e. when namespaces are watched, automatically disable CRD management) but let the user set it because I could want to make KES working with a set of namespaces but it's still the only KES in the cluster. |
5ad8e6a
to
43526b0
Compare
43526b0
to
351a866
Compare
@Flydiverny I've updated the branch to fix the conflict after latest changes (about timeout) :-) |
Any update on this |
Love to get this merged but with E2E tests failing its blocked. |
…lti namespaces inside the watcher method
🎉 |
Hello,
This PR is 1 of 2 PRs to address support for multitenancy.
At the moment KES is not scoped, which means it works cluster-wide and there is no way to scope its access. Thus, cannot deploy 2 KES in the same cluster will different access.
So this PR allows allow to watch
externalsecrets
in specified namespaces which fix a couple of issues:I've already finished the main implementation (the last part could be supporting regex in namespaces name instead of static names), now I need to update the tests and docs.