-
Notifications
You must be signed in to change notification settings - Fork 404
'Failed to get /openapi/v2 and /swagger.json: Created Component, but require templated one' #576
Comments
Oh weird, for me it was |
@silasbw any chance fluent-openapi could not hard fail on this? Seems to appear more and more :( |
Hi, we are having this exact same issue; sure enough, backing out the prometheus-adapter fixed it. This issue, #563 , mentions that 0.8.2 changed the openapi custom.metrics.k8s.io endpoint and that's what broke external-secrets 6.0.0. Is there a plan to adjust external-secrets to accomodate whatever change occurred in prometheus-adapter 0.8.2? |
@jbilliau-rcd KES is using some dependencies which in turn is using https://github.com/silasbw/swagger-fluent which is the library that isn't able to handle this. |
@Flydiverny thanks for the response; is the nutshell of this then that, in order to use external-secrets and prometheus adapter together, we need to stay on 0.7.0 of the adapter and not upgrade for the forseeable future? No biggie if that's the case, this controller has a been a big hit with our devs so if we have to make accommodations to keep using it, so be it. |
@Flydiverny can you please elaborate on what exactly the swagger-fluent library isn't able to handle? |
@dudicoco not really. But the error originates from the library :) |
I got this error as well in an effort to upgrade to EKS 1.18 and take several charts along with it (with the stable repo now gone). Luckily this was an easy find. adapter v0.8.3 was released moments ago, so I'm going to give it a try to see if that fixed anything, but if not I hope the problem doesn't persist unsolved for too long. |
I'm running into similar issue and i'm not sure how to resolve it, please find below the details of the issue
as shown above, the main issue is This is the command line that I run to install this plugin
does anyone have an idea on how to resolve it? Thanks in advance! |
I've found the root cause of my problem above. (Not sure if it applicable to you as well) in my EKS, i'm using security groups for pods, each pod will be associated to an ENI and this ENI will be attached to security group. When I removed this feature and redeploy this plugin, everything went well. This means, could be a missing security group rules to allow specific inbound/outbound to EKS control plane (where the API Server returns the requested json call made by this plugin as mentioned in the title above). For the time being, I will remove the security group from the namespace where this plugin is deployed until someone can provide a solution or knows how to fix it using the security group feature). Hope this help! |
@Flydiverny it seems that this library is now affecting a few different components (prometheus-adapter, kube-metrics-adapter, aws-node eni) and is preventing from upgrading or implementing new features (aws sgs for pods is a more critical one). |
@dudicoco Its not so much about priority as finding someone willing/able to dig into it :) |
Digged a little bit. So, it's failing on this endpoint:
Without I don't really understand the logic there, but it seems wrong: while (nextSplits.length) {
const split = nextSplits.shift()
splits.push(split)
let template = null
if (nextSplits.length && nextSplits[0].startsWith('{')) {
template = nextSplits.shift().slice(1, -1)
} |
@Flydiverny anyone looking into this issue? It seems to be a big one that conflicts custom metrics api and does not seem to be going way, I dont think there is a workaround to make everything work. |
kubernetes-sigs/prometheus-adapter#341 (comment) IIUC the rewrite is nowhere near ready for prime-time and the fix that needs to be applied is upstream, here, with pretty much no traction on that PR since it was submitted in May. Perhaps we can all 👍 that PR and try to kickstart inertia over there? Or is there another openapi client we can swap in here to negate the issue in the meantime? I certainly agree this is a bummer – we are now eternally pinned to 0.7.0 of the prometheus-adapter pending the v0 release of an untested rewrite. I intend to contribute on that front and am not trying to be negative here, at all – our setup is functional and I am quite grateful for this software – but this feels like gridlock, as it stands. |
So we just noticed that we were bit by this as well. However, going back to the the prometheus-adapter 0.7.0 didn't help us. Deleting the APIService does, but then that makes the prometheus-adapter useless, right? For now we are disabling the prometheus-adapter.. but that seems like the wrong fix here. What can be done to help move a fix forward here? |
@diranged We got this working. Using 6.0.0 of the external-secrets chart, and 2.8.1 of the prometheus-adapter chart; have it installed on 50+ clusters, working fine. chart: |
If anyone was curious chart version 2.8.1 for prometheus-adapter is app version v0.7.0 - apiVersion: v1
appVersion: v0.7.0
created: "2020-12-05T10:58:46.558955576Z"
description: A Helm chart for k8s prometheus adapter
digest: 85e2ebab3925c7f0ae0fb481210e5716993840ca63855a793ded1dd4113753d1
home: https://github.com/DirectXMan12/k8s-prometheus-adapter
keywords:
- hpa
- metrics
- prometheus
- adapter
maintainers:
- email: [email protected]
name: mattiasgees
- name: steven-sheehy
- email: [email protected]
name: hectorj2f
name: prometheus-adapter
sources:
- https://github.com/kubernetes/charts
- https://github.com/DirectXMan12/k8s-prometheus-adapter
urls:
- https://github.com/prometheus-community/helm-charts/releases/download/prometheus-adapter-2.8.1/prometheus-adapter-2.8.1.tgz
version: 2.8.1 |
This did work for us but I had to completely rip out all remnants of prometheus adapter and then install v2.8.1 of the chart then install v6 of external-secrets. Then it worked. |
I'm a bit confused on Why a prometheus adapter is a dependency for this app and what they have to do with each other. I installed it on a barebones cluster just fine so it seems not needed. Can the offending call just be skipped or let the failure just be ignored? |
It isn't a dependancy, they share one. |
My workaround: switching from prometheus-adapter to keda.sh |
My recommendation is to switch to the GoLang-based https://github.com/external-secrets/external-secrets controller that is being more actively developed. It works well and is a fairly easy switch. |
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Any updates to this? |
I too faced this today, migrating to ESO is the way to go :) |
Here is the error I get when I installed v6.0.0 on aws eks
Here is the values.yaml I used to install:
The text was updated successfully, but these errors were encountered: