This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat: adds lodash get function for nested keys lookup #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonbattista
changed the title
Flydiverny
reviewed
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the Vault backend, only top-level properties can be used for formatting Secrets: https://github.com/external-secrets/kubernetes-external-secrets/blob/master/lib/backends/kv-backend.js#L47
We would like to be able to support nested property lookups for more complex Vault JSON secrets.
I added a simple lodash implementation to check whether the nested property exists, then fetch the value if it does.