This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
feat(project): add nodemon for development #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
silasbw
suggested changes
Dec 14, 2018
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "scripts": { | |||
| "coverage": "nyc ./node_modules/mocha/bin/_mocha --recursive lib", | |||
| "lint": "eslint-godaddy --ignore-pattern /coverage/ ./", | |||
| "start": "./bin/daemon.js", | |||
| "start": "if [ \"$DISABLE_NODEMON\" = \"true\" ]; then bin/daemon.js; else nodemon bin/daemon.js; fi", | |||
There was a problem hiding this comment.
add a "nodemon" script instead of doing the config from the environment variable.
silasbw
reviewed
Dec 14, 2018
package.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "coverage": "nyc ./node_modules/mocha/bin/_mocha --recursive lib", | |||
| "lint": "eslint-godaddy --ignore-pattern /coverage/ ./", | |||
| "start": "./bin/daemon.js", | |||
| "start-development": "nodemon ./bin/daemon.js", | |||
There was a problem hiding this comment.
imo "nodemon" is clearer and more explicitly communicates what's going on. it also matches other internal projects.
There was a problem hiding this comment.
Absolutely, I didn't know we have this convention.
silasbw
approved these changes
Dec 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.