This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Show error on missing property #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polling function was not outputting an error message when a property is missing from a secret.
jeffpearce
reviewed
Jun 6, 2019
| @@ -35,6 +35,11 @@ class KVBackend extends AbstractBackend { | |||
| this._logger.warn(`Failed to JSON.parse '${value}':`, err) | |||
| return | |||
| } | |||
|
|
|||
| if (!(secretProperty.property in parsedValue)) { | |||
| throw new Error('Could not find property ' + secretProperty.property + ' in ' + secretProperty.key) | |||
There was a problem hiding this comment.
Thanks for the pul request! Could you add a unit test for this case?
Also, it's probably better to check parsedValue[secretProperty.property] to match the rest of the code, or even check the result on line 43 before returning.
There was a problem hiding this comment.
Not sure I understand... parsedValue[secretProperty.property] could contain an empty value, so checking that wouldn't help with verifying if the property exists.
silasbw
approved these changes
Jun 6, 2019
| @@ -64,7 +64,8 @@ class Poller { | |||
| return this._upsertKubernetesSecret({ secretDescriptor }) | |||
| })) | |||
| } catch (err) { | |||
| this._logger.error('failure while polling the secrets', err) | |||
| this._logger.error('failure while polling the secrets') | |||
| this._logger.error(err.toString()) | |||
There was a problem hiding this comment.
nit: this._logger.error(err) should work
| @@ -35,6 +35,11 @@ class KVBackend extends AbstractBackend { | |||
| this._logger.warn(`Failed to JSON.parse '${value}':`, err) | |||
| return | |||
| } | |||
|
|
|||
| if (!(secretProperty.property in parsedValue)) { | |||
| throw new Error('Could not find property ' + secretProperty.property + ' in ' + secretProperty.key) | |||
There was a problem hiding this comment.
nit
throw new Error(`Could not find property ${secretProperty.property} in ${secretProperty.key}`)
|
@kenske we just pushed version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polling function was not outputting an error message when a property is missing from a secret. This addresses #63 .