This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Add ownerreference to remove created secret when external secret is removed #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasbw
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Hey, thanks for submitting this 💯!
@JacopoDaeli can you do a once over too?
jeffpearce
approved these changes
Jun 20, 2019
|
Didn't update test yet so Travis is legit in failing :) I can update tomorrow #EUtime |
|
Test updated |
|
Thanks for the PR @Flydiverny ! |
|
This change is included in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Not sure how you would like it configureable and what kind of defaults?
Figured I'd just draft a PR first 😄
Im abit unsure about whether I plugged it in, in the right place. Seeing how
secretDescriptorsis an array being sent around, but its always just one?I could add the ownerReference into the
secretDescriptorobject (https://github.com/godaddy/kubernetes-external-secrets/pull/95/files#diff-5c2754430010d5f3e95b45e1bb36d58bR55) but it feels weird to put it in there as well as its just some metadata and not part of the secretDescriptor