Resolves #17 #18
Resolves #17 #18
Conversation
| Future _writeNewPubSpec( | ||
| File pubSpec, Version oldVersion, Version newVersion) async { | ||
| String newPubSpec = pubSpec.readAsStringSync().replaceFirst( | ||
| 'version: "${oldVersion}"', "version: " + '"${newVersion.toString()}"'); |
There was a problem hiding this comment.
What if a different quotation is used?
version: '1.2.3+4'or
version: 1.2.3+4There was a problem hiding this comment.
True, thanks. The ouput shouldn't matter but for the input I guess it's better to use a simple regex. I'll add it.
|
Thanks for the PR. I'd like to see the pubspec manipulation logic extracted to a separate class. This way we could use it also for reading the version and get rid of the entire |
|
Good idea. I'll do that. I'll (possibly) also try to add this feature further down in the pubspec package or so. But after a quick glance I didn't find an easy way. In any case, if it gets added further down the pipe, we can just remove the code here again and revert to |
|
Sure. Open another PR to this branch, I'll help with refactoring. |
Resolves issue #17 by not using pubspec package for writing new version, but by searching for the version string in the pubspec file, incrementing it and writing back the string to the pubspec file.