Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to verify linked modules work #1896

Closed
3 tasks done
Timer opened this issue Mar 27, 2017 · 2 comments
Closed
3 tasks done

Add tests to verify linked modules work #1896

Timer opened this issue Mar 27, 2017 · 2 comments

Comments

@Timer
Copy link
Contributor

Timer commented Mar 27, 2017

We're about to add support for linked modules.
First, however, we need to add test cases.

Essentially, we want to add tests for a couple cases and validate these work in the test, dev, and production environment:

  • link to a package with newly introduced dependencies
  • link to a package which specifies peer deps in our main project, barring installed dev dependencies (maybe covered by below case)
  • Use required webpack loader only in cra project but missing from linked dep
@Timer
Copy link
Contributor Author

Timer commented Mar 27, 2017

If possible, we want to also test that a:

  • version of a dependency specified in the linked dependency is used over existing app (e.g. major version change with breaking incompatibility)

@Timer Timer added this to the 0.9.6 milestone Mar 27, 2017
@Timer
Copy link
Contributor Author

Timer commented Mar 31, 2017

#1912 and #1913

@Timer Timer closed this as completed Mar 31, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant