-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create-react-app overrides dependencies in my custom react-scripts template #2462
Comments
The issue is that reading it from Old versions used to run two installs: first for I’m open to suggestions for fixing this, but not at the expense of the install time for most users. |
could there be a postInstall hook (maybe read it from the template package.json)? In this case that script could uninstall/install the needed packages... Other option is to run |
I think that if you need it to install something other than React, you might as well use a forked global package (since technically it doesn’t “create React app” anymore). So I’ll close this, but I can take a PR that runs |
Sure! So far I have got used to live with the fact, that I need to replace React->Preact manually. |
An update here. Some time before, CRA introduced newer From the good news: error overlay works with Preact very well, giving me a better development experience without any issues along the way. |
FYI: The next version of the overlay will be bundled and you will not need to worry about React compat. |
I am maintaining fork with a custom react-scripts package, which is based on Preact.
After the change, #1253 has been released the
create-react-app
command always installs the fixed set of packages do not usepackage.json
from template folder anymore.Sorry that I did not report it before because usually the update for global command
create-react-app
is not required and I had stuck at some old version. Recently I have got a report from users, just-boris#17 about that problem.As a workaround, I have recommended installing
preact
manually, but it doesn't seem like a good solution.Can I ask to change the behavior and pick up dependencies from project
template
folder instead of the hard-coded list withreact
andreact-dom
?The text was updated successfully, but these errors were encountered: