Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixes strange gradient appears when using borderTopLeftRadius (or similar) not uniform #49531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #49442. We should enable Rasterize when we draw the contents by ourselves. Otherwise, it may produce strange gradient.

Changelog:

[IOS] [FIXED] - Fixes strange gradient appears when using borderTopLeftRadius (or similar) not uniform

Test Plan:

Repro please see #49442.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 19, 2025
@joevilches
Copy link
Contributor

Hmm I am not the most familiar with the implications of shouldRasterize on CALayer, but it seems like it could have quite a large impact and is not something we would want to naively turn on for every border/outline layer we make, especially if the issue we are seeing is rather specific (scaling transform on parent with custom border drawing on child).

I would assume that there is some fix to the logic in the border drawing we have that would let us fix this problem without having to set this value, which would be ideal. If you want to tackle this issue can you go down that avenue as a potential solution? The code would live in RCTBorderDrawing.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Strange gradient appears when using borderTopLeftRadius (or similar) inside a scaled View
3 participants