Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some assertions left in production mode #5871

Closed
AlexGalays opened this issue Jan 17, 2016 · 2 comments
Closed

Some assertions left in production mode #5871

AlexGalays opened this issue Jan 17, 2016 · 2 comments

Comments

@AlexGalays
Copy link

A few assertions are left in the production output (using webpack -p if that matters) as they're not located inside an if(env) block; Could squeeze a few bytes!

Examples:

"You provided a `checked` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultChecked`. Otherwise, set either `onChange` or `readOnly`.
dangerouslySetInnerHTML` must be set using `updateInnerHTMLByID()`.",style:"`style` must be set using `updateStylesByID()`.
You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`."
@jimfb
Copy link
Contributor

jimfb commented Jan 17, 2016

The second message was fixed in #5205

The first and third will probably be cleaned up as part of #2302, but I suppose we can keep this issue open until that happens.

@aweary
Copy link
Contributor

aweary commented Sep 20, 2017

None of these assertions exist in the latest 15 or 16 RC release 🎉

@aweary aweary closed this as completed Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants