Merge pull request #1170 from vbrazo/fixes/wrong-parse-ru-methods

First_name and last_name should use the parse method - :ru locale
faker-ruby · May 12, 2018 · d4a8df3 · d4a8df3
2 parents 5b5d342 + 4b28a6e
commit d4a8df3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/faker/name.rb b/lib/faker/name.rb
@@ -13,11 +13,11 @@ def name_with_middle
       end
 
       def first_name
-        fetch('name.first_name')
+        parse('name.first_name')
       end
 
       def last_name
-        fetch('name.last_name')
+        parse('name.last_name')
       end
 
       def prefix

diff --git a/test/test_faker_name.rb b/test/test_faker_name.rb
@@ -14,6 +14,14 @@ def test_name_with_middle
     assert @tester.name_with_middle.match(/(\w+\.? ?){3,4}/)
   end
 
+  def test_first_name
+    assert @tester.first_name.match(/(\w+\.? ?){3,4}/)
+  end
+
+  def test_last_name
+    assert @tester.last_name.match(/(\w+\.? ?){3,4}/)
+  end
+
   def test_prefix
     assert @tester.prefix.match(/[A-Z][a-z]+\.?/)
   end