-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deprecate IDNumber to IdNumber per issue#2787
- Loading branch information
1 parent
0576cce
commit fdc7d4b
Showing
12 changed files
with
142 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,52 @@ | ||
| # Faker::IDNumber | ||
| # Faker::IdNumber | ||
|
|
||
| ```ruby | ||
| # Generate a valid US Social Security number | ||
| Faker::IDNumber.valid #=> "552-56-3593" | ||
| Faker::IdNumber.valid #=> "552-56-3593" | ||
|
|
||
| # Generate an invalid US Social Security number | ||
| Faker::IDNumber.invalid #=> "311-72-0000" | ||
| Faker::IdNumber.invalid #=> "311-72-0000" | ||
|
|
||
| # Generate a Spanish citizen identifier (DNI) | ||
| Faker::IDNumber.spanish_citizen_number #=> "53290236-H" | ||
| Faker::IdNumber.spanish_citizen_number #=> "53290236-H" | ||
|
|
||
| # Generate a Spanish foreign born citizen identifier (NIE) | ||
| Faker::IDNumber.spanish_foreign_citizen_number #=> "Z-1600870-Y" | ||
| Faker::IdNumber.spanish_foreign_citizen_number #=> "Z-1600870-Y" | ||
|
|
||
| # Generate a valid South African ID Number | ||
| Faker::IDNumber.south_african_id_number #=> "8105128870184" | ||
| Faker::IdNumber.south_african_id_number #=> "8105128870184" | ||
| # or | ||
| Faker::IDNumber.valid_south_african_id_number #=> "8105128870184" | ||
| Faker::IdNumber.valid_south_african_id_number #=> "8105128870184" | ||
|
|
||
| # Generate an invalid South African ID Number | ||
| Faker::IDNumber.invalid_south_african_id_number #=> "1642972065088" | ||
| Faker::IdNumber.invalid_south_african_id_number #=> "1642972065088" | ||
|
|
||
| # Generate a Brazilian citizen number (CPF) | ||
| # Keyword arguments: formatted | ||
| Faker::IDNumber.brazilian_citizen_number #=> "53540542221" | ||
| Faker::IDNumber.brazilian_citizen_number(formatted: true) #=> "535.405.422-21" | ||
| Faker::IdNumber.brazilian_citizen_number #=> "53540542221" | ||
| Faker::IdNumber.brazilian_citizen_number(formatted: true) #=> "535.405.422-21" | ||
|
|
||
| # Generate a Brazilian ID Number (RG) | ||
| # Keyword arguments: formatted | ||
| Faker::IDNumber.brazilian_id #=> "493054029" | ||
| Faker::IDNumber.brazilian_id(formatted: true) #=> "49.305.402-9" | ||
| Faker::IdNumber.brazilian_id #=> "493054029" | ||
| Faker::IdNumber.brazilian_id(formatted: true) #=> "49.305.402-9" | ||
|
|
||
| # Generate a Chilean ID (Rut with 8 digits) | ||
| # For more advanced cases, please refer to Faker::ChileRut | ||
| Faker::IDNumber.chilean_id #=> "15620613-K" | ||
| Faker::IdNumber.chilean_id #=> "15620613-K" | ||
|
|
||
| # Generate a Croatian ID number (OIB) | ||
| # Keyword arguments: international | ||
| Faker::IDNumber.croatian_id #=> "88467617508" | ||
| Faker::IDNumber.croatian_id(international: true) #=> "HR88467617508" | ||
| Faker::IdNumber.croatian_id #=> "88467617508" | ||
| Faker::IdNumber.croatian_id(international: true) #=> "HR88467617508" | ||
|
|
||
| # Generate a Danish ID number (CPR) | ||
| # Keyword arguments: formatted, gender, birthday | ||
| Faker::IDNumber.danish_id_number #=> "050390-9980" | ||
| Faker::IDNumber.danish_id_number(formatted: true) #=> "050390-9980" | ||
| Faker::IDNumber.danish_id_number(birthday: Date.new(1990, 3, 5)) #=> "050390-9980" | ||
| Faker::IDNumber.danish_id_number(gender: :female) #=> "050390-9980" | ||
| Faker::IdNumber.danish_id_number #=> "050390-9980" | ||
| Faker::IdNumber.danish_id_number(formatted: true) #=> "050390-9980" | ||
| Faker::IdNumber.danish_id_number(birthday: Date.new(1990, 3, 5)) #=> "050390-9980" | ||
| Faker::IdNumber.danish_id_number(gender: :female) #=> "050390-9980" | ||
|
|
||
| # Generate a valid French Social Security number (INSEE number) | ||
| Faker::IDNumber.french_insee_number #=> "22510589696868" | ||
| Faker::IdNumber.french_insee_number #=> "22510589696868" | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Faker | ||
| def self.const_missing(const_name) | ||
| new_class = DeprecatedClass.names[const_name.to_sym] | ||
| super(const_name) unless new_class | ||
| warn "DEPRECATION WARNING: the class Faker::#{const_name} is deprecated. Use Faker::#{new_class} instead." | ||
| Object.const_get("Faker::#{new_class}") | ||
| end | ||
|
|
||
| class Movies | ||
| def self.const_missing(const_name) | ||
| Faker.const_missing("Movies::#{const_name}") | ||
| end | ||
| end | ||
|
|
||
| class DeprecatedClass | ||
| # rubocop:disable Lint/SymbolConversion | ||
| def self.names | ||
| { | ||
| 'IDNumber': 'IdNumber', | ||
| 'Movies::HarryPotterDeprecated': 'Movies::HarryPotter' | ||
| } | ||
| end | ||
| # rubocop:enable Lint/SymbolConversion | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| en: | ||
| faker: | ||
| id_number: | ||
| valid: "#{IDNumber.ssn_valid}" | ||
| valid: "#{IdNumber.ssn_valid}" | ||
| invalid: ['000-##-####', '###-00-####', '###-##-0000', '666-##-####', '9##-##-####'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require_relative '../../test_helper' | ||
|
|
||
| class TestFakerDeprecatedClass < Test::Unit::TestCase | ||
| def setup | ||
| @tester = Faker::DeprecatedClass | ||
| end | ||
|
|
||
| def test_non_nested_class_with_deprecated_class | ||
| actual_stdout, actual_stderr = capture_output do | ||
| Faker::IDNumber.valid | ||
| end | ||
|
|
||
| assert_empty actual_stdout | ||
| assert_match('DEPRECATION WARNING: the class Faker::IDNumber is deprecated. Use Faker::IdNumber instead.', actual_stderr) | ||
| end | ||
|
|
||
| def test_nested_class_with_deprecated_class | ||
| actual_stdout, actual_stderr = capture_output do | ||
| Faker::Movies::HarryPotterDeprecated.character | ||
| end | ||
|
|
||
| assert_empty actual_stdout | ||
| assert_match('DEPRECATION WARNING: the class Faker::Movies::HarryPotterDeprecated is deprecated. Use Faker::Movies::HarryPotter instead.', actual_stderr) | ||
| end | ||
| end |
Oops, something went wrong.