Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First names are in english when initiating faker with local "ru" #1024

Closed
baubakg opened this issue Sep 13, 2017 · 2 comments
Closed

First names are in english when initiating faker with local "ru" #1024

baubakg opened this issue Sep 13, 2017 · 2 comments
Assignees

Comments

@baubakg
Copy link
Contributor

baubakg commented Sep 13, 2017

Hello,

This is a great project:

Tested this with the russian locale, and tried outputs for the name values and got:

The output is:

fullname : Герман Белозеров
firstname : Katheryn
last name : Tremblay
street address : Свердлова ул., 216
21631654

As you can see although the fullname is in russian, the first and last name remain in english.

baubakg added a commit to baubakg/faker that referenced this issue Sep 13, 2017
…es are in english when initiating faker with local ru
stympy pushed a commit that referenced this issue Oct 13, 2017
@vbrazo
Copy link
Member

vbrazo commented May 13, 2018

@baubakg How do you feel about this issue?

I have worked on a PR related to this issue recently. My goal was to fix an error and you can check the reference out in this issue. Please let me know if we could close this PR or not.

Thanks.

@vbrazo
Copy link
Member

vbrazo commented Jun 2, 2018

@baubakg I tested the ru locales and now it seems to be working correctly. Feel free to reopen this issue or create another one in case you find other problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants