-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing documentation - Faker::Address to Faker::Myst #1252
Conversation
Since you're working with Docs maybe you could clean this |
@rafaelcpalmeida definitely 👍 |
0eaac3b
to
20b7350
Compare
@vbrazo I can work backwards and we can meet in the middle? |
@mrstebo what do you mean? |
@vbrazo I'll start from the top of the list of modules. So I'll start looking at |
Awesome. Start in It'd be nice if you could open the console |
@@ -3,5 +3,5 @@ | |||
```ruby | |||
Faker::Community.characters #=> "Jeff Winger" | |||
|
|||
Faker::Community.quote #=> I fear a political career could shine a negative light on my drug dealing." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to deprecate this method, because the Faker::Community
hasn't been released yet.
…mentation Add missing documentation - Faker::Address to Faker::Myst
I'm reviewing the documentation vs APIs to see if we're missing docs.
Docs that are missing documentation:
Faker::Address.full_address
Faker::Artist
Faker::BreakingBad
Faker::Code.npi
- reported by @mrstebo and fixed Added missing documentation for Code faker. Fixes #1251 #1254Faker::Code.rut
- reported by @mrstebo and fixed Added missing documentation for Code faker. Fixes #1251 #1254Faker::Code.nric
- reported by @mrstebo and fixed Added missing documentation for Code faker. Fixes #1251 #1254Faker::Commerce.promotion_code(5)
Faker::Commerce.price(range = 0..100.0, as_string = true)
Faker::Company.type
was in the docs, it had locales but it didn't have a method and a test lolFaker::Dota.quote
with paramsFaker::Esport - README.md
Faker::Finance
Faker::FunnyName - README.md
Faker::GameOfThrones.quote
Faker::HitchhikersGuideToTheGalaxy - README.md
Faker::Internet.fix_umlauts
Faker::Lebowski - README.md and docs
Faker::Lorem.question and Faker::Lorem.questions
This PR is related to this issue #1251.