Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export the stream types from the types file #622

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

Fergmux
Copy link
Contributor

@Fergmux Fergmux commented Mar 19, 2022

Notes

The index.d.ts file was missing the export for the Stream type declarations, this PR simply adds them as an export to that file.

How to test

npm link this repo to another that imports this module, try to import a stream related type from the 'faunadb' module (such as Subscription) and verify the Module '"faunadb"' has no exported member 'Subscription'. error does not appear.

Screenshots

Before adding the export:
Screenshot 2022-03-19 at 15 47 15

After adding the export:
Screenshot 2022-03-19 at 15 58 00

@henryfauna henryfauna merged commit e6bb72e into fauna:v4 Sep 14, 2022
trevor-fauna added a commit that referenced this pull request Sep 15, 2022
* chore(deps-dev): bump terser from 4.8.0 to 4.8.1 (#650)

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump semantic-release from 17.4.7 to 19.0.3 (#644)

Bumps [semantic-release](https://github.com/semantic-release/semantic-release) from 17.4.7 to 19.0.3.
- [Release notes](https://github.com/semantic-release/semantic-release/releases)
- [Commits](semantic-release/semantic-release@v17.4.7...v19.0.3)

---
updated-dependencies:
- dependency-name: semantic-release
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* export the stream types from the types file (#622)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Fergus Mullineux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants