Fix for issue #365

[kaushalvivek]

Instead of keeping the results for a search query limited to 1, increased it to 10.

Line changed:
https://github.com/carpedm20/fbchat/blob/89a277c3541e5b5a5a1b4c1dd6aaf9025ce43707/fbchat/client.py#L505

[madsmtm]

Thanks for your contribution, and don't mind the broken tests.

Would it make sense to increase the limit on searchForPages, searchForGroups and searchForThreads equivalently?

[kaushalvivek]

@madsmtm , I would say yeah. Two people/threads/pages might have the same name (as is for a lot of Indian names :P), and this does render searching futile when only one object is being returned. A limit of 3, 5 or 10, would be the best balance between being pragmatic and maintaining usability at the same time. That's just my opinion.

[madsmtm]

This would technically be a breaking change if people were doing something like:

try:
    user, = client.searchForUsers("abc")
except:
    pass  # Assume the user couldn't be found

But that's bad usage of the method anyhow, so I don't think it'll be a problem.

I'll merge this once you've updated the limit on searchForPages, searchForGroups and searchForThreads as well :)

[kaushalvivek]

Have updated the limits on searchForPages, searcForGroups and searchForThreads to 10 as well, also looked at why it was failing tests.

[madsmtm]

Thanks 👍

[AuroraRin]

Emergency !!!!! Can any one help me out with the sendLocalVoiceClip, when I run the code it keeps saying that:
'FacebookMess' object has no attribute 'sendLocalVoiceClips'
Ps: My fbchat is 1.6.3. Thanks in advance~

[madsmtm]

Hi @AuroraRin, I'm sorry to hear that you're having trouble, and would love to help you out! Unfortunately, this is not the correct place to discuss the issue. Please create a dedicated bug report, and attempt to fill in as much information as you can, then I'll get back to you 😊