Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t run the download query in API if the estimate is over 500K #3614

Closed
lbeaufort opened this issue Mar 11, 2019 · 2 comments
Closed

Don’t run the download query in API if the estimate is over 500K #3614

lbeaufort opened this issue Mar 11, 2019 · 2 comments
Labels
Needs prioritization Needs refinement
Milestone
Sprint 8.6

Comments

@lbeaufort
Copy link
Member

Downloads are running whole query before telling user it’s too big, which defeats the purpose of the size limit if they're able to bypass the CMS
@lbeaufort lbeaufort added this to the Sprint 8.3 milestone Mar 12, 2019
@lbeaufort lbeaufort self-assigned this Mar 14, 2019
@lbeaufort
Copy link
Member Author

After doing a code review, it looks like this might not be an issue, but I need to test to be sure.

@JonellaCulmer JonellaCulmer modified the milestones: Sprint 8.3, Sprint 8.4 Mar 19, 2019
@lbeaufort lbeaufort removed their assignment Mar 19, 2019
@pkfec pkfec modified the milestones: Sprint 8.4, Sprint 8.5 Mar 28, 2019
@pkfec pkfec modified the milestones: Sprint 8.5, Sprint 8.6 Apr 11, 2019
@patphongs
Copy link
Member

After code review, we determined that this was not an issue

@patphongs patphongs mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs prioritization Needs refinement
Projects
None yet
Milestone
Sprint 8.6
Development

No branches or pull requests
4 participants
@pkfec @patphongs @lbeaufort @JonellaCulmer