Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research rewrite to remove 'import app' #4448

Open
4 tasks
lbeaufort opened this issue Jul 4, 2020 · 1 comment · May be fixed by #6148
Open
4 tasks

Research rewrite to remove 'import app' #4448

lbeaufort opened this issue Jul 4, 2020 · 1 comment · May be fixed by #6148
Assignees
@cnlucas
Labels
Technical debt Work: Back-end

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Jul 4, 2020 •
edited by JonellaCulmer
Loading

What we're after:
We should rewrite to remove 'import app'. This is an anti-pattern.
https://flask.palletsprojects.com/en/2.3.x/patterns/appfactories/

This is blocking flask sqlalchemy/sqlalchemy upgrades.

Action items:

  • Consider talking to DBA team about sample data
  • Build out a plan/model for this change
  • Create follow-up implementation ticket(s)

Completion criteria:

  • Research has been documented here in the ticket

Future work:

  • Look at the CMS
@rochacbruno
Copy link

Let me know if you need some eyes on it, I would be happy to help on it, I was reading the source code and maybe dynaconf can help making the code easier to maintain by putting all the registration and configuration in config files. (bias allert! I am the Dynaconf maintainer)

My slides on that topic are here: https://skip.gg/flask-factories-flaskcon and recordings

@patphongs patphongs removed this from the PI 13 innovation 1 milestone Oct 28, 2020
@cnlucas cnlucas added this to the Sprint 24.2 milestone Jan 29, 2024
@cnlucas cnlucas assigned cnlucas and unassigned tmpayton Feb 15, 2024
@patphongs patphongs moved this to Assigned in Website project Feb 23, 2024
@cnlucas cnlucas modified the milestones: Sprint 24.2, Sprint 24.3 Feb 27, 2024
@patphongs patphongs mentioned this issue Feb 29, 2024
Open
25 tasks
@cnlucas cnlucas modified the milestones: 24.3, 24.4 Mar 12, 2024
@cnlucas cnlucas modified the milestones: 24.4, 24.5 Mar 26, 2024
@cnlucas cnlucas modified the milestones: 24.5, 24.6 Apr 9, 2024
@cnlucas cnlucas modified the milestones: 24.6, 24.i Apr 23, 2024
@cnlucas cnlucas modified the milestones: 24.i, 25.1 May 14, 2024
@cnlucas cnlucas modified the milestones: 25.1, 25.2 May 28, 2024
@cnlucas cnlucas modified the milestones: 25.2, 25.3 Jun 11, 2024
@cnlucas cnlucas modified the milestones: 25.3, 25.4 Jun 25, 2024
@cnlucas cnlucas modified the milestones: 25.4, 25.5 Jul 9, 2024
@cnlucas cnlucas modified the milestones: 25.5, 25.6 Jul 23, 2024
@cnlucas cnlucas modified the milestones: 25.6, 25.i Aug 7, 2024
@cnlucas cnlucas modified the milestones: 25.i, 26.1 Aug 26, 2024
@cnlucas cnlucas modified the milestones: 26.1, 26.4 Sep 6, 2024
@cnlucas cnlucas removed this from the 26.4 milestone Oct 3, 2024
@cnlucas cnlucas linked a pull request Feb 21, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnlucas cnlucas

Labels
Technical debt Work: Back-end
Projects
Website project
Status: 📥 Assigned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/4448 switch to app factory fecgov/openFEC
6 participants
@rochacbruno @patphongs @lbeaufort @JonellaCulmer @cnlucas @tmpayton