Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove in repo metrics code #255

Closed
hannahhoward opened this issue May 25, 2023 · 0 comments · Fixed by #286
Closed

Remove in repo metrics code #255

hannahhoward opened this issue May 25, 2023 · 0 comments · Fixed by #286
Assignees
@kylehuntsman
Labels
tech debt Non-critical change that can wait to be addressed
Milestone
Extended Support

Comments

@hannahhoward
Copy link
Collaborator

What

The Lassie library itself shouldn't write metrics -- it should be handled through the events callbacks. Also, these metrics are not actually in use, so I'd just suggest deleting them for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehuntsman kylehuntsman

Labels
tech debt Non-critical change that can wait to be addressed
Projects
None yet
Milestone
Extended Support
Development

Successfully merging a pull request may close this issue.

Remove metrics and prometheus exporter filecoin-project/lassie
2 participants
@hannahhoward @kylehuntsman