Logging logs wrong file and line due to "lazy" function

[RobQuistNL]

Checklist

• This is not a security-related bug/issue. If it is, please follow please follow the security policy.
• This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
• This is not a new feature request. If it is, please file a feature request instead.
• This is not an enhancement request. If it is, please file a improvement suggestion instead.
• I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
• I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
• I did not make any code changes to lotus.

Lotus component

• lotus daemon - chain sync
• lotus miner - mining and block production
• lotus miner/worker - sealing
• lotus miner - proving(WindowPoSt)
• lotus miner/market - storage deal
• lotus miner/market - retrieval deal
• lotus miner/market - data transfer
• lotus client
• lotus JSON-RPC API
• lotus message management (mpool)
• Other

Lotus Version

1.14.0-rc1

Describe the Bug

This bit of code: https://github.com/filecoin-project/lotus/blob/v1.14.0-rc1/chain/vm/runtime.go#L637-L648 causes any logs to be written as if they were coming from that line.

Example:

2022-01-14T03:41:14.567+0100    INFO    actors  vm/runtime.go:633       RepayDebtsOrAbort was called and succeeded
2022-01-14T03:41:14.567+0100    INFO    actors  vm/runtime.go:633       RepayDebtsOrAbort was called and succeeded
2022-01-14T03:41:14.567+0100    INFO    actors  vm/runtime.go:633       RepayDebtsOrAbort was called and succeeded
2022-01-14T03:41:14.568+0100    INFO    actors  vm/runtime.go:633       RepayDebtsOrAbort was called and succeeded

The line vm/runtime.go:633 reflects this line, not the original line it was called - this entire function should either be removed or it should be reflecting the originating calls' line & file.

[arajasek]

I've been annoyed by this myself, it makes it hard to debug stuff in actors. Unfortunately, I'm not sure how possible this is -- this is the logger that is provided to actors code, and I don't know of a way for it to log the LoC in actors that triggers it.

Maybe someone else knows?

[arajasek]

@Stebalien offers this, thanks steb