This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat: singularity swagger client #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijaharita
force-pushed
the
feat/singularity-swagger-client
branch
from
8d00228 to
173586a
Compare
hannahhoward
approved these changes
Sep 8, 2023
go.mod
Outdated
| @@ -3,167 +3,109 @@ module github.com/filecoin-project/motion | |||
| go 1.20 | |||
|
|
|||
| require ( | |||
| github.com/data-preservation-programs/singularity v0.3.1-0.20230908045144-b48f89bbe21e | |||
There was a problem hiding this comment.
we should make sure before we merge this that we cut a Singularity v0.4.0 tag
There was a problem hiding this comment.
we may need v0.4.1 because it requires a bug fix from a PR i have open and 0.4.0 has already been merged (ListAttachedWallets swagger client returns models.ModelWallet when it should return []models.ModelWallet)
elijaharita
force-pushed
the
feat/singularity-swagger-client
branch
from
e6e1ab4 to
51f84bc
Compare
Merged
elijaharita
force-pushed
the
feat/singularity-swagger-client
branch
from
15cfac6 to
42cfcdf
Compare
elijaharita
force-pushed
the
feat/singularity-swagger-client
branch
from
c8855ae to
60d5d8b
Compare
elijaharita
added a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates motion to use singularity's new swagger client instead of the old hand-written http/lib clients, which are removed in xinaxu's Storage/Preparation refactor
closes #81
closes #121 i think