This repository has been archived by the owner on May 15, 2024. It is now read-only.
Add S3 connector integration tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testing of s3 connector to devnet integration tests. This change will then remove the need to duplicate integration test setup in motion-s3-connector repo, and would help us catch breaking changes early since the devnet instance started up in `motion` repo builds the motion container from `main` branch.
masih
force-pushed
the
masih/s3-connector-it
branch
from
acd079a to
45059fc
Compare
masih
added a commit
to filecoin-project/motion-s3-connector
that referenced
this pull request
Sep 11, 2023
Remove integration tests from here and move to `motion` repo, in order to: * reduce duplicate CI setup, since motion repo already stands up a devnet for testing. * make sure the connector remains compatible with the latest commit to main of Motion repo. See: - filecoin-project/motion#117
masih
added a commit
to filecoin-project/motion-s3-connector
that referenced
this pull request
Oct 5, 2023
Remove integration tests from here and move to `motion` repo, in order to: * reduce duplicate CI setup, since motion repo already stands up a devnet for testing. * make sure the connector remains compatible with the latest commit to main of Motion repo. See: - filecoin-project/motion#117
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing of s3 connector to devnet integration tests.
This change will then remove the need to duplicate integration test setup in motion-s3-connector repo, and would help us catch breaking changes early since the devnet instance started up in
motionrepo builds the motion container frommainbranch.