Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Tag singularity metrics to motion #177

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Tag singularity metrics to motion #177

merged 3 commits into from
Oct 23, 2023

Conversation

xinaxu
Copy link
Collaborator

@xinaxu xinaxu commented Oct 23, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #177 (0532392) into main (d35c382) will increase coverage by 0.79%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   30.82%   31.61%   +0.79%     
==========================================
  Files           5        5              
  Lines         743      756      +13     
==========================================
+ Hits          229      239      +10     
- Misses        479      480       +1     
- Partials       35       37       +2     
Files Coverage Δ
integration/singularity/store.go 36.42% <50.00%> (+1.13%) ⬆️

@xinaxu xinaxu requested a review from masih October 23, 2023 19:30
@xinaxu xinaxu merged commit bb873c7 into main Oct 23, 2023
@xinaxu xinaxu deleted the xinaxu/telemetry branch October 23, 2023 22:25
xinaxu added a commit that referenced this pull request Oct 25, 2023
Follow-up of 
#177 

Motion container starts after other Singularity container starts hence
setting identity inside motion container does not take effect until the
user restart the docker compose.

To address above issue, we can set the identity to Motion during Admin
init script.

Tested end to end and see data reflected on Dashboard

https://dataprograms.grafana.net/d/f49ba403-a767-4243-af44-607dec1e7100/usage?orgId=1

fixes #174
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants