Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix: clean up error logging (logging + returning identical errors) #194

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

elijaharita
Copy link
Contributor

fixes #144

@elijaharita elijaharita requested a review from gammazero October 28, 2023 01:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #194 (020c76e) into main (51e4d29) will increase coverage by 0.79%.
The diff coverage is 7.69%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   31.66%   32.45%   +0.79%     
==========================================
  Files           5        5              
  Lines         777      761      -16     
==========================================
+ Hits          246      247       +1     
+ Misses        494      477      -17     
  Partials       37       37              
Files Coverage Δ
integration/singularity/options.go 24.13% <0.00%> (ø)
integration/singularity/store.go 37.97% <8.00%> (+1.44%) ⬆️

@elijaharita elijaharita merged commit d78f35b into main Nov 1, 2023
@elijaharita elijaharita deleted the fix/cleanup-error-logging branch November 1, 2023 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not log error and then return same error
3 participants