This repository has been archived by the owner on May 15, 2024. It is now read-only.
Setup wallets for singularity #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
masih
reviewed
Aug 29, 2023
| singularityClient client.Client | ||
| } | ||
|
|
||
| func NewSingularityStore(dir string, singularityClient client.Client) *SingularityStore { | ||
| func NewSingularityStore(dir string, wallet *wallet.Wallet, singularityClient client.Client) *SingularityStore { |
There was a problem hiding this comment.
Alternatives I can think of are:
- Move all the config into a package and pass that around
- pro: simpler
- con: not all stores have the same config, meaning we end up with irrelevant config for some stores.
- Take a storeCreator as an option in Motion and let store define its own options.
- pro: each store has full control over its options
- con: more boilerplate.
Jiffy implements its own motion store, with bespoke options. How I see it work is that it would then create its own executable, with a "motion compatible HTTP API". This means the point of compatibility between Jiffy and Motion is the Motion API spec, not Motion configuration. |
hannahhoward
force-pushed
the
feat/singularity-wallets
branch
from
3e4b4c7 to
784866a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Implements #54
Implementations
@masih I am curious to see how you do this for Jiffy when you get to your integration test. It doesn't feel great that this all lives inside the blob store but I don't see another way to do it.
For now: