This repository has been archived by the owner on May 15, 2024. It is now read-only.
Run automated integrations with devnet
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/devnet-ci
branch
2 times, most recently
from
695cfc0 to
6b31407
Compare
masih
force-pushed
the
masih/devnet-ci
branch
from
b12a6d4 to
2d73237
Compare
masih
changed the title
devnet
masih
added a commit
that referenced
this pull request
Sep 8, 2023
Set up devnet instantiation via GitHub Actions using pre-built images from lotus devnet and boost to speed up the build. Set up CI caching to further speed up the testing for filecoin proof parameter downloads. As a result the entire devnet setup takes under 2 minutes. Build the motion container from branch every time to test that current checked out branch does not break integration. The integration test added in this PR is very minimal: it tests a round-trip PUT/GET to motion API. To reduce the scope of this PR further testcases will be added in separate commits. See: - https://github.com/filecoin-shipyard/lotus-containers
masih
force-pushed
the
masih/devnet-ci
branch
from
67e95f9 to
37609c6
Compare
masih
added a commit
that referenced
this pull request
Sep 8, 2023
Set up devnet instantiation via GitHub Actions using pre-built images from lotus devnet and boost to speed up the build. Set up CI caching to further speed up the testing for filecoin proof parameter downloads. As a result the entire devnet setup takes under 2 minutes. Build the motion container from branch every time to test that current checked out branch does not break integration. The integration test added in this PR is very minimal: it tests a round-trip PUT/GET to motion API. To reduce the scope of this PR further testcases will be added in separate commits. See: - https://github.com/filecoin-shipyard/lotus-containers
masih
force-pushed
the
masih/devnet-ci
branch
from
37609c6 to
17a93e9
Compare
hannahhoward
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
LGTM
As you said in conversation, I think there's a follow-up ticket to add to the integration test to verify we're actually storing all the way to the Boost nodes.
However, even the test you have should fail if singularity setup fails, cause the API will never be spun up if the singularity store initialize fails, at least I think.
Please merge at will -- considering this approved, with questions mostly for my own edification.
Set up devnet instantiation via GitHub Actions using pre-built images from lotus devnet and boost to speed up the build. Set up CI caching to further speed up the testing for filecoin proof parameter downloads. As a result the entire devnet setup takes under 2 minutes. Build the motion container from branch every time to test that current checked out branch does not break integration. The integration test added in this PR is very minimal: it tests a round-trip PUT/GET to motion API. To reduce the scope of this PR further testcases will be added in separate commits. See: - https://github.com/filecoin-shipyard/lotus-containers
masih
force-pushed
the
masih/devnet-ci
branch
from
2240981 to
a9d8552
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up devnet instantiation via GitHub Actions using pre-built images from lotus devnet and boost to speed up the build.
Set up CI caching to further speed up the testing for filecoin proof parameter downloads. As a result the entire devnet setup takes under 2 minutes.
Build the motion container from branch every time to test that current checked out branch does not break integration.
The integration test added in this PR is very minimal: it tests a round-trip PUT/GET to motion API. To reduce the scope of this PR further testcases will be added in separate commits.
See:
Fixes #60