This repository has been archived by the owner on May 15, 2024. It is now read-only.
Move singularity to a dedicated package and parameterize constants #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Singularity store has grown complex enough to deserve its own dedicated package in Motion. Move it to a dedicated package. The options at top level Motion seem to be largely used by Singularity. Refactor the options to give Singularity store implementation the flexibility to define the options it needs while removing the ripple effect of them on the rest of the repo. The changes here move all Singularity specific options to the new `singularity` packge under integration. Parameterise hardcoded max CAR size and pack threshold in Singularity store as CLI flags. This is necessary to run Motion with Singularity store for devnet testing. Unrelated to PR: refine make extern/filecoin-ffi command for a more concise definition.
willscott
approved these changes
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singularity store has grown complex enough to deserve its own dedicated package in Motion. Move it to a dedicated package.
The options at top level Motion seem to be largely used by Singularity. Refactor the options to give Singularity store implementation the flexibility to define the options it needs while removing the ripple effect of them on the rest of the repo. The changes here move all Singularity specific options to the new
singularitypackge under integration.Parameterise hardcoded max CAR size and pack threshold in Singularity store as CLI flags. This is necessary to run Motion with Singularity store for devnet testing.
Unrelated to PR: refine make extern/filecoin-ffi command for a more concise definition.