This repository has been archived by the owner on May 15, 2024. It is now read-only.
Support Testnet mode #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cli option to use in a lotus testnet, updating various parameters based on that
|
Would this be necessary in motion considering max car size and pack threshold are parameterised already? |
Yes, I think. The baseline problem is the string output used for addresses, which is hardcoded in the go-address repo. This is relevant for the schedule creation which contains string addresses. Suffice to say I had to do this to get everything working BEFORE I actually made those functions that are now parameters around MaxCarSize and Pack Threshold |
|
Good to know thanks |
masih
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Add cli option to use in a lotus testnet. This is important cause while not obvious, all lotus addreses are serialized by go-address based off a global package var (bizarre behavior, but subject for another time). So they will read either "t..." or "f..." when written as a string based on address.CurrentNetwork.