Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate creation of GitHub releases and tags #2027

Closed
wants to merge 8 commits into from
Closed

ci: automate creation of GitHub releases and tags #2027

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
084c879
ci: automate creation of GitHub releases and tags
galargh Jul 23, 2024
c0aa24f
docs: update documentation on release creation
galargh Jul 23, 2024
c4fa7c0
feat: release individual packages
galargh Jul 27, 2024
2292bc1
fix: trigger release workflows on Cargo.toml changes
galargh Jul 27, 2024
85586da
chore: simplify cargo-publish job check
galargh Jul 28, 2024
50273e3
ci: limit duplication in release workflows
galargh Aug 5, 2024
a3fb5a9
docs: document the new release process and possible improvements
galargh Aug 13, 2024
423e826
chore: apply suggestions from code review
galargh Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/release-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Release Checker

on:
pull_request_target:
paths: ["Cargo.toml"]
types: [ opened, synchronize, reopened, labeled, unlabeled ]
workflow_dispatch:

permissions:
contents: write
pull-requests: write

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
release-check:
uses: ipdxco/unified-github-workflows/.github/workflows/[email protected]
with:
sources: '["Cargo.toml"]'
21 changes: 21 additions & 0 deletions .github/workflows/releaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Releaser

on:
push:
paths: ["Cargo.toml"]
workflow_dispatch:

permissions:
contents: write

concurrency:
group: ${{ github.workflow }}-${{ github.sha }}
cancel-in-progress: true

jobs:
releaser:
uses: ipdxco/unified-github-workflows/.github/workflows/[email protected]
with:
sources: '["Cargo.toml"]'
secrets:
UCI_GITHUB_TOKEN: ${{ secrets.UCI_GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Once the release is prepared, it'll go through a review:

Finally, an [FVM "owner"](https://github.com/orgs/filecoin-project/teams/fvm-crate-owners/members) will:

1. Merge the release PR to master.
1. Merge the release PR to master (this will trigger GitHub release/tag creation if the workspace version in the root `Cargo.toml` was modified).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this complete? Are there steps from #2027 (comment) we need to include? I don't see discussion about opening a PR which creates a draft Release and that when we merge the PR we get a published Release.

And are the comments about an FVM owner still needing to run cargo publish accurate? (or are we only doing a dryrun as part of CI?)

2. For each released crate, create a git tag: `crate_name@crate_version`.
3. Run `cargo publish` for each released crate (in dependency order).

Expand Down
Loading