Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning from compileReleaseKotlin Gradle task #6

Closed
loopedresolve opened this issue Aug 1, 2024 · 1 comment
Closed

Warning from compileReleaseKotlin Gradle task #6

loopedresolve opened this issue Aug 1, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@loopedresolve
Copy link
Contributor 

> Task :smoldotkotlin:compileReleaseKotlin
w: file:///project/smoldotkotlin/src/main/java/io/finsig/smoldotkotlin/Client.kt:77:20 Condition is always 'false'.
@loopedresolve loopedresolve added the good first issue Good for newcomers label Aug 1, 2024
@loopedresolve
Copy link
Contributor Author

This compiler warning should be ignored. This null check is required because the JNI method smoldotAwaitNextJSONRPC2Response(id) can indeed return a NULL pointer that will otherwise result in a crash.

@loopedresolve loopedresolve closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
@loopedresolve loopedresolve pinned this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loopedresolve