feat!: Set the RopeJoint's local anchors to null vectors by default #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Aug 22, 2022
alestiago
suggested changes
Aug 22, 2022
kjagiello
force-pushed
the
bugfix/rope-joint-local-anchors
branch
from
2a78cbb to
0ae3b81
Compare
kjagiello
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This caused me some headache yesterday during the gamejam. The rope joint behaved weirdly and did not follow the physics and I would expect it to do. Some investigation lead me to realize that the local anchors had a non-zero default. Setting them to zero vectors gave me the result I was looking for. I think it is reasonable to remove the old default to not cause any future confusion.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change