Calculate megabundle as soon as it's received #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruteri
force-pushed
the
calculate-megabundle-instantly
branch
from
f4e9cec to
25e9d32
Compare
jparyani
approved these changes
Feb 3, 2022
tkstanczak
reviewed
Feb 6, 2022
If you notice here https://github.com/flashbots/mev-geth/pull/112/files#diff-689874b30f6f905ce6c47cdefeddcf052b467a7936a981f4b6cf38939e10d924R457 that the megabundle interrupt is submitted with "interrupt none", it will not stop the previous task (whatever it may be). So if we are getting more requests than we can handle, we still produce blocks as fast as we can, and the (non-) interrupts are queued. If a different interrupt is submitted (head/recommit) the higher interrupt is propagated to the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since megabundles are only sent if they improve the profit over previous megabundle, they should be considered for mining immediately.