Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect integer conversion #10188

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Fix incorrect integer conversion #10188

merged 3 commits into from
Mar 1, 2023

Conversation

zwass
Copy link
Member

@zwass zwass commented Feb 28, 2023

This was caught by CodeQL. We parsed as a 64 bit but then convert to a (possibly 32 bit) uint. It would be 64 bit on most platforms, but we actually use a 32 bit int type in MySQL as well.

@zwass
Fix incorrect integer conversion
a33f39a 
This was caught by CodeQL. We parsed as a 64 bit but then convert to
a (possibly 32 bit) `uint`. It would be 64 bit on most platforms, but we
actually use a 32 bit `int` type in MySQL as well.
@zwass zwass requested a review from a team as a code owner February 28, 2023 19:08
sharon-fdm
sharon-fdm previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (145f143) 60.53% compared to head (a1ceb01) 60.68%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10188      +/-   ##
==========================================
+ Coverage   60.53%   60.68%   +0.15%     
==========================================
  Files         499      500       +1     
  Lines       51135    51240     +105     
==========================================
+ Hits        30953    31094     +141     
+ Misses      17301    17254      -47     
- Partials     2881     2892      +11
Impacted Files Coverage Δ
server/fleet/packs.go 29.78% <100.00%> (+25.53%) ⬆️
server/fleet/app.go 8.18% <0.00%> (-0.91%) ⬇️
server/datastore/mysql/apple_mdm.go 60.44% <0.00%> (-0.23%) ⬇️
server/fleet/teams.go 0.00% <0.00%> (ø)
server/mdm/apple/apple_mdm.go 0.00% <0.00%> (ø)
server/service/orbit_client.go 0.00% <0.00%> (ø)
orbit/pkg/profiles/profiles_notdarwin.go 100.00% <0.00%> (ø)
server/service/testing_client.go 97.47% <0.00%> (+0.03%) ⬆️
server/service/osquery.go 72.06% <0.00%> (+0.16%) ⬆️
server/service/appconfig.go 69.10% <0.00%> (+0.18%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwass zwass temporarily deployed to Docker Hub March 1, 2023 01:14 — with GitHub Actions Inactive
@zwass zwass temporarily deployed to Docker Hub March 1, 2023 01:28 — with GitHub Actions Inactive
@zwass zwass requested a review from lucasmrod March 1, 2023 01:30
sharon-fdm
sharon-fdm approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@sharon-fdm sharon-fdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@zwass zwass merged commit 9b1583b into main Mar 1, 2023
@zwass zwass deleted the incorrect-integer-conversion branch March 1, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharon-fdm sharon-fdm sharon-fdm approved these changes

@lucasmrod lucasmrod Awaiting requested review from lucasmrod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwass @sharon-fdm