Move parsers to the library #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxo
reviewed
Dec 11, 2019
src/main.rs
Outdated
| @@ -93,7 +93,7 @@ fn run() -> Result<(), Error> { | |||
| .map(|v| usize::from_str(v).expect("Invalid head arguement")); | |||
|
|
|||
| let filter = filter::from_args_profile(&args, &profile)?; | |||
| let mut parser = parser::Parser::new(); | |||
| let mut parser = parser::Parser::with_default_rules(); | |||
src/parser.rs
Outdated
| pub fn with_default_rules() -> Self { | ||
| Parser { | ||
| parsers: vec![ | ||
| Box::new(formats::DefaultParser {}), |
src/parser.rs
Outdated
| Box::new(formats::GTestParser {}), | ||
| Box::new(formats::BugReportParser {}), | ||
| ], | ||
| last: None, | ||
| } | ||
| } | ||
|
|
||
| pub fn parse(&mut self, line: String) -> Record { |
There was a problem hiding this comment.
Think changing this to &str can avoid to move the String. There is no need to actually move the line.
`serde_derive`. Works around the issue, when using `rogcat` as a library; see serde-rs/serde#1441
1. Implemented Default trait.
2. Removed unnecessary {}s.
3. Use &str instead of String.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.