Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default font on Windows #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StevenLu2004
Copy link

I was a MacOS user, and the default font of fman used to work fine for me. I switched to Windows lately, but the font was not loaded; instead, fman showed me a very ugly default font. I checked the original fman-users/Core repo and used the "Theme (Windows).css" as my template for custom CSS, and I found that Roboto works, whereas "Roboto Bold" doesn't (because Qt misinterprets it as the font's name, not the name and style); then I tried "font-weight: bold" with "font-family: Roboto" and achieved desired results. See images below.

with Roboto Bold
with Roboto and font-weight:bold

@mherrmann
Copy link
Contributor

I appreciate the PR; But it changes the fonts in a bad way. The fonts shouldn't be bold. Without your change, my fman looks as follows:

image

With your change, it looks as follows:

image

Removing font-weight: bold doesn't change this; The fonts are still rendered bold.

I believe you are experiencing something that's very particular to your system. I think it should be fixed on your system, not in fman itself because neither I nor to my best knowledge other people are experiencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants