fix(forge): forge build --sizes collapses non uniques

[zerosnacks]

Motivation

Closes: #9961

Previously, because of a flat BTreeMap, we were not preserving path-unique contracts in the --sizes table

Solution

Now includes the path, stripped by project root as the unique identifier only in cases where clashing occurs

╭-----------------------------+------------------+-------------------+--------------------+---------------------╮
| Contract                    | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
+===============================================================================================================+
| Counter (src/Counter.sol)   | 481              | 509               | 24,095             | 48,643              |
|-----------------------------+------------------+-------------------+--------------------+---------------------|
| Counter (src/a/Counter.sol) | 344              | 372               | 24,232             | 48,780              |
|-----------------------------+------------------+-------------------+--------------------+---------------------|
| Counter (src/b/Counter.sol) | 291              | 319               | 24,285             | 48,833              |
|-----------------------------+------------------+-------------------+--------------------+---------------------|
| Foo                         | 62               | 88                | 24,514             | 49,064              |
╰-----------------------------+------------------+-------------------+--------------------+---------------------╯

and with --json:

{
   "Counter (src/Counter.sol)":{
      "runtime_size":481,
      "init_size":509,
      "runtime_margin":24095,
      "init_margin":48643
   },
   "Counter (src/a/Counter.sol)":{
      "runtime_size":344,
      "init_size":372,
      "runtime_margin":24232,
      "init_margin":48780
   },
   "Counter (src/b/Counter.sol)":{
      "runtime_size":291,
      "init_size":319,
      "runtime_margin":24285,
      "init_margin":48833
   },
   "Foo":{
      "runtime_size":62,
      "init_size":88,
      "runtime_margin":24514,
      "init_margin":49064
   }
}

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[grandizzy]

Makes sense. Not sure if we should display path to artifact or actually path to source file, wdyt?

[zerosnacks]

Makes sense. Not sure if we should display path to artifact or actually path to source file, wdyt?

Ah yes, that makes much more sense - fixed in 7e9020c

[grandizzy]

lgtm! Don't think there's any implications on json output?

[zerosnacks]

lgtm! Don't think there's any implications on json output?

it does not, added test for completeness

the only implication is that in the JSON output it would also show with the path in the name

{
   "Counter (src/Counter.sol)":{
      "runtime_size":481,
      "init_size":509,
      "runtime_margin":24095,
      "init_margin":48643
   },
   "Counter (src/a/Counter.sol)":{
      "runtime_size":344,
      "init_size":372,
      "runtime_margin":24232,
      "init_margin":48780
   },
   "Counter (src/b/Counter.sol)":{
      "runtime_size":291,
      "init_size":319,
      "runtime_margin":24285,
      "init_margin":48833
   },
   "Foo":{
      "runtime_size":62,
      "init_size":88,
      "runtime_margin":24514,
      "init_margin":49064
   }
}

I would classify it as a fix rather than a breaking change, previously it would show just one "Counter": { ... } which is incorrect