This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
GRANDPA bridge #106
Merged
GRANDPA bridge #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
…os-ownership-node into feat/grandpa-bridge
ghost
commented
Aug 4, 2023
tonimateos
approved these changes
Aug 4, 2023
asiniscalchi
approved these changes
Aug 4, 2023
asiniscalchi
added a commit
that referenced
this pull request
Aug 9, 2023
* Delete polkadot-launch directory * Remove `template` mentions from runtime * Fix clippy * first hello world test * fmt * checking the selectors * testdata updated * renaming * added testdata for owner_of * removed a type declaration * fmt * using macro to help using behavior pattern testing * usign macro * refactoring * refactoring * main tests covered * name refactoring * removed unused dependency * removed testdata * add test on calling unexsiting selector * removed unused code * fix returning errors message * fmt * adding explicit value transferred in tests, and making explicit both methods supported * removing unreachable path * added tests that the implemented methods are non-payable * using closures * refactoring * declare name in temoplate * refactoring PrecompileMock -> Mock * created handle_from_input * added docuemntation * renaming: define_precompile_mock -> define_precompile_mock_simple * renaming: define_precompile_mock_closure -> impl_precompile_mock * name refactoring * refactoring: handle_from_input use create_mock_handle * refactoring: handle_from_input -> create_mock_handle_from_input * comment the inputs * using constants * first try * add create collection returning id to trati * fix compilation * trait crate_collection2 returns Result * test on create collection failure * create collection returns an id * precompiled return from pallet * added create_collection returning id in solidity interface * assign caller as owner * remove legacy create collection in precompile * removed create_collection2 from trait * compiling * compiling * create collection extrinsic create consecutive collections * removed legacy code from solidity interface * create file traits.rs * trait LivingAssetOwnership -> CollectionManager * doc: solidity * documentation * better tests * better testing * fix typo * conversion collection_id to address * removed owner of from precompile * adding test that create_collection is non-payable * checking err is as expected: "non payable" * fixing a test that was failing for a different reason, as shown by testing that the error received was as expected * fix compilation * fix compilation * adding event * added event Create Collection * fmt * copied MockHandle to implement log function * GRANDPA bridge (#106) * Only client side compile errors * Upgrade to v1.0.0 * Add grandpa bridge to runtime * Fix clippy and tests * Fix lints * Fix tests and clippy * Remove comment * test log selector * remove dependency * Mock logs logs * testing event * removed duplicated test * using succeed utility * collection_it_to_addressis private * return value is correctly encoded as a n Address (#109) * return value is correctly encoded as a n Address * removed outdated comment * fix the documentation * precompile erc 721 only owner_of (#104) * create mock and testing * first test * testing ethereum reserved addresses * refactoring * refactoring * refactoring tests * fmt * erc721 starting point * fmt * compiling * check selectors * create trait Erc721 * Erc721Precompile * set mocks * first implermentation * first integration of erc721 in the runtime * fmt * check on the collection id * test on extract owner form asset_id * fix tests * test for erc721 trait * fix compilation * refactoring * returning address * return value is correctly encoded as a n Address * is_erc721_contract is not member of PrecompoileSet * test on precompiled contracts * erc721 returns hardcoded address * refactoring * testing return of asset ownership * fix errors * remove unused use * refactoring * rewriting testing mod * refactoring * moving check for cllection address in pallet * collection address prefix changed * test passing * test passing * refactoring tests * do not panic the runtime * fmt * solidity tokenId -> _tokenId * erc721 functions are views * update docs * sp-core in std , removed duplicate function * documentaetion * using compilator type ifer * compiler infer the size of the array * added to std feature * rename variable * trait documentation * fmt * runtime spec to 4 * fix name on LivingAssetsOwnership pallet (#120) --------- Co-authored-by: dastan <[email protected]> Co-authored-by: Dastan Samatov <[email protected]> Co-authored-by: Toni Mateos <[email protected]>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also upgrades dependencies to
polkadot-v1.0.0