Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FCS caches instance, not static #440

Closed
dsyme opened this issue Oct 15, 2015 · 1 comment
Closed

Make FCS caches instance, not static #440

dsyme opened this issue Oct 15, 2015 · 1 comment

Comments

@dsyme
Copy link
Contributor

dsyme commented Oct 15, 2015

This cache is module-static - it should be inside the IncrementalBuilder object. https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/vs/IncrementalBuild.fs#L1090

This would be a problem if the user creates multiple FSHarpChecker objects as they could end up using the same cache (which is likely not logically valid as the structures being cached would belong to different compilations)
@dsyme
Copy link
Contributor Author

dsyme commented Oct 15, 2015

See #443

@dsyme dsyme closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsyme