Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fyne cli tool removes Migration section of FyneApp.toml #51

Open
2 tasks done
pneumaticdeath opened this issue Feb 16, 2025 · 5 comments
Open
2 tasks done

fyne cli tool removes Migration section of FyneApp.toml #51

pneumaticdeath opened this issue Feb 16, 2025 · 5 comments
Labels
blocker Blocking upcoming release

Comments

@pneumaticdeath
Copy link

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When I do a release build using the latest (v1.0.0-alpha1) fyne cli tool, it removes the Migration section of the FyneApp.toml file.

How to reproduce

  1. Add Migration block to FyneApp.toml
  2. Use fyne cli to build a release version for a android or iOS platform
  3. Notice block is now missing

Screenshots

titania:KarmaManager mitch$ git diff
diff --git a/FyneApp.toml b/FyneApp.toml
index be25fad..19fda57 100644
--- a/FyneApp.toml
+++ b/FyneApp.toml
@@ -5,13 +5,10 @@ Website = "https://patenaude.io/"
   Name = "KarmaManager"
   ID = "io.patenaude.karmamanager"
   Version = "0.1.0"
-  Build = 131
+  Build = 133

 [LinuxAndBSD]
   GenericName = "Anagram Maker"
   Categories = ["Game"]
   Comment = "Make Anagrams"
   Keywords = ["game"]
-
-[Migration]
-  fyneDo = true
titania:KarmaManager mitch$ fyne version
fyne cli version: v1.0.0-alpha1

### Example code

```bash
fyne release --target ios --certificate "${IOSDISTROCERT}" --profile "${IOSDISTROPROF}"

Fyne version

v2.6.0-alpha1

Go compiler version

1.23.4

Operating system and version

MacOS Sonoma 14.6.1

Additional Information

No response

@Jacalz
Copy link
Member

Jacalz commented Feb 17, 2025

Is this the new cli tool or the old one? Does the cmd tool print a warning that it is deprecated when you run it? It should do that if it hasn’t been installed from the new location. If this is still an issue with the new tool, I will move the issue over to the right repository.

@pneumaticdeath
Copy link
Author

I included the version of the CLI tool in the original report, but it is:

titania:KarmaManager mitch$ fyne version
fyne cli version: v1.0.0-alpha1

@Jacalz
Copy link
Member

Jacalz commented Feb 18, 2025

Yes I know but that doesn't answer my question. The cmd/fyne tool in this repository is deprecated in 2.6 and has moved to https://github.com/fyne-io/tools. Does this issue correspond to the new one or the old one?

@pneumaticdeath
Copy link
Author

Sorry, didn't realize they would report the same version info..

Just to be sure I re-installed the command line tool:

titania:KarmaManager mitch$ go install fyne.io/tools/cmd/[email protected]

and tried again:

titania:KarmaManager mitch$ ls -l $(which fyne)
-rwxr-xr-x  1 mitch  staff  18497602 Feb 18 01:50 /Users/mitch/go/bin/fyne
titania:KarmaManager mitch$ fyne version
fyne cli version: v1.0.0-alpha1
titania:KarmaManager mitch$ grep Migration FyneApp.toml
[Migration]
titania:KarmaManager mitch$ ./test_on ios
titania:KarmaManager mitch$ grep Migration FyneApp.toml
titania:KarmaManager mitch$

So, I'm pretty sure it's the new tool.

@Jacalz Jacalz transferred this issue from fyne-io/fyne Feb 18, 2025
@Jacalz Jacalz added the blocker Blocking upcoming release label Feb 18, 2025
@Jacalz
Copy link
Member

Jacalz commented Feb 18, 2025

They wouldn’t necessarily report the same version (didn't quite look at the exact version printed out) but wanted to confirm that the issue was opened in the wrong place. Moved it to be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocking upcoming release
Projects
None yet
Development

No branches or pull requests

2 participants