Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new todo creates a .todos.json in current directory instead of adding it to global .todos.json #219

Closed
tcassaert opened this issue Sep 23, 2020 · 6 comments · Fixed by #220

Comments

@tcassaert
Copy link
Contributor

When I create a new todo, it creates by default a new .todos.json when there is none in the current directory. I expected it to add the new todo to the .todos.json in my home directory.

@gammons
Copy link
Owner

gammons commented Sep 23, 2020

Hi @tcassaert this is by design. See the docs here.

@gammons gammons closed this as completed Sep 23, 2020
@tcassaert
Copy link
Contributor Author

Maybe I've not explained the issue clear enough.

With the latest version, the current behavior is happening:

I have a .todos.json in my home directory. When I am in another directory, let's say in /tmp where there is no .todo.json file, and I add a new todo, there is a file created /tmp/.todos.json.

According to the docs, it should use the .todos.json in my home directory in this situation, and not create a new .todos.json file in /tmp.

@gammons
Copy link
Owner

gammons commented Sep 23, 2020

ohhhh. yeah. that's an issue!

@gammons gammons reopened this Sep 23, 2020
@gammons
Copy link
Owner

gammons commented Sep 23, 2020

I replicated this. thanks for finding it!

@gammons
Copy link
Owner

gammons commented Sep 24, 2020

@tcassaert just published 1.5.1 which fixes this issue. thanks again!

@mahiki
Copy link

mahiki commented Oct 8, 2020

Awesome, thanks for acting so quickly on this. I didn't notice this happening after upgrading to v1.2, ended up littering my folders wtih a few .todo.json files, but not hard to remediate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants