Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-remark-images] When using showCaption, parse the caption as markdown #14474

Closed
mathieudutour opened this issue May 31, 2019 · 4 comments · Fixed by #16574 or #21188
Closed

[gatsby-remark-images] When using showCaption, parse the caption as markdown #14474

mathieudutour opened this issue May 31, 2019 · 4 comments · Fixed by #16574 or #21188

Comments

@mathieudutour
Copy link
Contributor

Summary

When using showCaptions: true as an option for the gatsby-remark-images, it inserts the title of the image as raw html.
How about considering the caption as markdown and parsing it before inserting it?

Motivation

mathieudutour/medium-to-own-blog#5

Happy to work on it if that's something that you find interesting

@freiksenet
Copy link
Contributor

It's a good idea. Could you make a PR with that change? I think it should be a new parameter, like markdownCaptions: true, so we preserve backwards compatability.

@freiksenet freiksenet self-assigned this Jun 4, 2019
@freiksenet freiksenet added the help wanted Issue with a clear description that the community can help with. label Jun 4, 2019
@freiksenet freiksenet removed their assignment Jun 4, 2019
@mathieudutour
Copy link
Contributor Author

Sounds good, will do

@jletey
Copy link
Contributor

jletey commented Jun 8, 2019

@mathieudutour If you are busy, I can give this a shot!

@gatsbot
Copy link

gatsbot bot commented Jun 29, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 29, 2019
@mathieudutour mathieudutour added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Jun 29, 2019
@mathieudutour mathieudutour removed the help wanted Issue with a clear description that the community can help with. label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants