Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Improve the release CI by including differential testing #18

Open
qd-qd opened this issue Jun 7, 2023 · 0 comments
Open

👷 Improve the release CI by including differential testing #18

qd-qd opened this issue Jun 7, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@qd-qd
Copy link
Member

qd-qd commented Jun 7, 2023

This repository includes a command that tests the current implementation against a reference one. However, this command is not included in any CI workflow because it is very consuming as it involves sagemath.

Include a mandatory step in the release CI workflow that runs the differential test. This step must install all the sagemath dependencies.

I expect the release workflow to be at least 7 minutes longer with this additional step, but I believe the security is worth the waiting. Feel free by the implementation I did here.

@qd-qd qd-qd added the good first issue Good for newcomers label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant