From 7ca663500167b7f78e280ac3e39d0aae77738d22 Mon Sep 17 00:00:00 2001
From: Billy Vong <billyvg@users.noreply.github.com>
Date: Wed, 16 Oct 2024 15:56:48 -0400
Subject: [PATCH] fix(replay): Fix `onError` callback

This fixes the `onError` callback added in https://github.com/getsentry/sentry-javascript/pull/13721 -- the option itself was not being propagated to the replay options.
---
 packages/replay-internal/src/integration.ts            |  2 ++
 .../test/integration/sendReplayEvent.test.ts           | 10 ++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/packages/replay-internal/src/integration.ts b/packages/replay-internal/src/integration.ts
index 8f70e3099a97..c3c448a3c6f2 100644
--- a/packages/replay-internal/src/integration.ts
+++ b/packages/replay-internal/src/integration.ts
@@ -114,6 +114,7 @@ export class Replay implements Integration {
 
     beforeAddRecordingEvent,
     beforeErrorSampling,
+    onError,
   }: ReplayConfiguration = {}) {
     this.name = Replay.id;
 
@@ -183,6 +184,7 @@ export class Replay implements Integration {
       networkResponseHeaders: _getMergedNetworkHeaders(networkResponseHeaders),
       beforeAddRecordingEvent,
       beforeErrorSampling,
+      onError,
 
       _experiments,
     };
diff --git a/packages/replay-internal/test/integration/sendReplayEvent.test.ts b/packages/replay-internal/test/integration/sendReplayEvent.test.ts
index a58da34b521c..29f063fa4b94 100644
--- a/packages/replay-internal/test/integration/sendReplayEvent.test.ts
+++ b/packages/replay-internal/test/integration/sendReplayEvent.test.ts
@@ -28,6 +28,7 @@ describe('Integration | sendReplayEvent', () => {
   let mockTransportSend: MockTransportSend;
   let mockSendReplayRequest: MockInstance<any>;
   let domHandler: DomHandler;
+  const onError: () => void = vi.fn();
   const { record: mockRecord } = mockRrweb();
 
   beforeAll(async () => {
@@ -44,6 +45,7 @@ describe('Integration | sendReplayEvent', () => {
         _experiments: {
           captureExceptions: true,
         },
+        onError,
       },
     }));
 
@@ -54,6 +56,7 @@ describe('Integration | sendReplayEvent', () => {
   });
 
   beforeEach(() => {
+    vi.clearAllMocks();
     vi.setSystemTime(new Date(BASE_TIMESTAMP));
     mockRecord.takeFullSnapshot.mockClear();
     mockTransportSend.mockClear();
@@ -357,8 +360,9 @@ describe('Integration | sendReplayEvent', () => {
     expect(replay).not.toHaveLastSentReplay();
   });
 
-  it('fails to upload data and hits retry max and stops', async () => {
+  it('fails to upload data, hits retry max, stops, and calls `onError` with the error', async () => {
     const TEST_EVENT = getTestEventIncremental({ timestamp: BASE_TIMESTAMP });
+    const ERROR = new Error('Something bad happened');
 
     const spyHandleException = vi.spyOn(SentryCore, 'captureException');
 
@@ -369,7 +373,7 @@ describe('Integration | sendReplayEvent', () => {
 
     // fail all requests
     mockSendReplayRequest.mockImplementation(async () => {
-      throw new Error('Something bad happened');
+      throw ERROR;
     });
     mockRecord._emitter(TEST_EVENT);
 
@@ -406,6 +410,8 @@ describe('Integration | sendReplayEvent', () => {
     // Replay has stopped, no session should exist
     expect(replay.session).toBe(undefined);
     expect(replay.isEnabled()).toBe(false);
+    expect(onError).toHaveBeenCalledTimes(5);
+    expect(onError).toHaveBeenCalledWith(ERROR);
 
     // Events are ignored now, because we stopped
     mockRecord._emitter(TEST_EVENT);