-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Rename inboundFiltersIntegration
to eventFiltersIntegration
#15434
Conversation
packages/angular/src/sdk.ts
Outdated
// TODO(v10): Replace with `eventFiltersIntegration` once we remove the deprecated `inboundFiltersIntegration` | ||
inboundFiltersIntegration(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wherever we currently add inboundFiltersIntegration
as a default integration, we can't simply swap it out. This is because it would break people filtering out the integration by its name. IMHO it's perfectly fine to keep this until the next major (or whenever we decide to remove the old name export) and then make the swap.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a valid case for renaming as this integration is different from the Inbound Filters in the UI.
Yup, that's one of my two reasons as for why I think we should rename this integration. I updated the issue with some reasons as to why I think the current name is suboptimal. |
74f968b
to
e12576e
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This PR deprecates and renames the
inboundFiltersIntegration
toeventFiltersIntegration
to improve the integration name and avoid ambiguity with the product. See #15431 for reasons for the renaming.ref #15431