Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Rename inboundFiltersIntegration to eventFiltersIntegration #15434

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 17, 2025

This PR deprecates and renames the inboundFiltersIntegration to eventFiltersIntegration to improve the integration name and avoid ambiguity with the product. See #15431 for reasons for the renaming.

ref #15431

@Lms24 Lms24 self-assigned this Feb 17, 2025
Comment on lines 36 to 37
// TODO(v10): Replace with `eventFiltersIntegration` once we remove the deprecated `inboundFiltersIntegration`
inboundFiltersIntegration(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wherever we currently add inboundFiltersIntegration as a default integration, we can't simply swap it out. This is because it would break people filtering out the integration by its name. IMHO it's perfectly fine to keep this until the next major (or whenever we decide to remove the old name export) and then make the swap.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.08 KB +0.12% +27 B 🔺
@sentry/browser - with treeshaking flags 22.86 KB +0.1% +23 B 🔺
@sentry/browser (incl. Tracing) 36.15 KB +0.05% +18 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.31 KB +0.04% +25 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.72 KB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.92 KB +0.03% +23 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.5 KB +0.03% +22 B 🔺
@sentry/browser (incl. Feedback) 40.23 KB +0.07% +26 B 🔺
@sentry/browser (incl. sendFeedback) 27.71 KB +0.11% +30 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.51 KB +0.09% +29 B 🔺
@sentry/react 24.9 KB +0.1% +24 B 🔺
@sentry/react (incl. Tracing) 38.03 KB +0.05% +18 B 🔺
@sentry/vue 27.32 KB +0.1% +26 B 🔺
@sentry/vue (incl. Tracing) 37.83 KB +0.05% +19 B 🔺
@sentry/svelte 23.12 KB +0.09% +19 B 🔺
CDN Bundle 24.29 KB +0.13% +31 B 🔺
CDN Bundle (incl. Tracing) 36.17 KB +0.07% +25 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.19 KB +0.06% +42 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.35 KB +0.03% +19 B 🔺
CDN Bundle - uncompressed 71 KB +0.11% +73 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 107.38 KB +0.07% +73 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.64 KB +0.04% +73 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.2 KB +0.04% +73 B 🔺
@sentry/nextjs (client) 39.2 KB +0.04% +16 B 🔺
@sentry/sveltekit (client) 36.56 KB +0.07% +24 B 🔺
@sentry/node 142.09 KB +0.01% +3 B 🔺
@sentry/node - without tracing 95.52 KB +0.01% +2 B 🔺
@sentry/aws-serverless 119.87 KB +0.02% +18 B 🔺

View base workflow run

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a valid case for renaming as this integration is different from the Inbound Filters in the UI.

@Lms24
Copy link
Member Author

Lms24 commented Feb 18, 2025

Yup, that's one of my two reasons as for why I think we should rename this integration. I updated the issue with some reasons as to why I think the current name is suboptimal.

@Lms24 Lms24 marked this pull request as ready for review February 26, 2025 16:15
@Lms24 Lms24 force-pushed the lms/feat-core-rename-inboundFilters branch from 74f968b to e12576e Compare February 26, 2025 16:20
Copy link

codecov bot commented Feb 26, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4688 1 4687 322
View the top 1 failed test(s) by shortest run time
manual-client/browser-context/test.ts allows to setup a client manually & capture exceptions
Stack Traces | 0.338s run time
test.ts:7:11 allows to setup a client manually & capture exceptions

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Lms24 Lms24 enabled auto-merge (squash) February 26, 2025 21:54
@Lms24 Lms24 merged commit e781ebe into develop Feb 26, 2025
151 checks passed
@Lms24 Lms24 deleted the lms/feat-core-rename-inboundFilters branch February 26, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants