Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode. #3522

Closed
lc6464 opened this issue Feb 7, 2021 · 3 comments
Closed

Support dark mode. #3522

lc6464 opened this issue Feb 7, 2021 · 3 comments
Assignees
Labels
triage Do not begin working on this issue until triaged by the team

Comments

@lc6464
Copy link

lc6464 commented Feb 7, 2021

What is the current behavior?

The https://docs.github.com website does not support dark mode.
Browser: Microsoft Edge 88.0.705.63

What changes are you suggesting?

Hope to add support for dark mode.

Additional information

Microsoft Edge supports dark mode CSS media queries.
image

@welcome
Copy link

welcome bot commented Feb 7, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@lc6464 lc6464 added the engineering Will involve Docs Engineering label Feb 7, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 7, 2021
@chiedo chiedo removed the engineering Will involve Docs Engineering label Feb 9, 2021
@chiedo
Copy link
Contributor

chiedo commented Feb 9, 2021

@simpsoka FYI!

@simpsoka
Copy link
Contributor

Thanks for opening this issue about dark mode for docs!

This has come up in the past, and we're actually in the middle of a site re-design, so we're rolling that out first and then we can look into supporting dark mode so that we get it to support the new design (not the old one).

With the new design, we're also looking at modular CSS - which will also help with adding darkmode. So I'm going to close this out for now and then we can get it on our backlog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

5 participants
@simpsoka @chiedo @lc6464 and others