-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lastest version of Breakdancer depends on react-native
#11
Comments
I am pro moving it to We've gone that way with other packages (as opposed to @fabiomcosta are you using |
react-native
react-native
@indexzero We use npm@4 ATM. |
Yes, that is what I am suggesting. Any PR making this change must include new documentation in |
The latest version of
breakdance
addedreact-native
as a peer dependency.Given
breakdance
supports both web and react-native "platforms" (AFAIK), I'd say this dependency is not desired.Another issue is that version 0.46.1 of
react-native
requiresreact
0.16.x andreact
version 0.15.x was also added as a peer dependency ofbreakdance
, which causes issues while installing it anyway.I honestly don't know, off the top of my head, the right solution to make
breakdancer
support RN while not forcing users of the library to have to depend on it, I'm not very experienced with projects that support both platforms, but I'd love to help with a PR if a good solution is suggested.The text was updated successfully, but these errors were encountered: