Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastest version of Breakdancer depends on react-native #11

Closed
fabiomcosta opened this issue Aug 28, 2017 · 3 comments
Closed

Lastest version of Breakdancer depends on react-native #11

fabiomcosta opened this issue Aug 28, 2017 · 3 comments

Comments

@fabiomcosta
Copy link
Contributor

fabiomcosta commented Aug 28, 2017

The latest version of breakdance added react-native as a peer dependency.
Given breakdance supports both web and react-native "platforms" (AFAIK), I'd say this dependency is not desired.
Another issue is that version 0.46.1 of react-native requires react 0.16.x and react version 0.15.x was also added as a peer dependency of breakdance, which causes issues while installing it anyway.

I honestly don't know, off the top of my head, the right solution to make breakdancer support RN while not forcing users of the library to have to depend on it, I'm not very experienced with projects that support both platforms, but I'd love to help with a PR if a good solution is suggested.

@indexzero
Copy link
Contributor

I am pro moving it to devDependencies with some additional copy in README.md about using this package with react-native.

We've gone that way with other packages (as opposed to devDependencies and peerDependencies) since npm@3 will not provide valid npm shrinkwrap with unmet peerDependencies. An investigation into this in an npm@5 world is prudent to update the practice.

@fabiomcosta are you using npm@3 or npm@5?

@indexzero indexzero changed the title Lastest version of Breakdance depends on react-native Lastest version of Breakdancer depends on react-native Aug 28, 2017
@fabiomcosta
Copy link
Contributor Author

@indexzero We use npm@4 ATM.
To clarify, are you suggesting to just remove it from peerDependencies? That should work fine for web.

@indexzero
Copy link
Contributor

Yes, that is what I am suggesting. Any PR making this change must include new documentation in README.md specifying that react-native is an implicit peer dependency for react-native scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants