Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup: Interactive children not removed from tabindex in init #15

Closed
goodguyry opened this issue Dec 11, 2019 · 0 comments · Fixed by #16
Closed

Popup: Interactive children not removed from tabindex in init #15

goodguyry opened this issue Dec 11, 2019 · 0 comments · Fixed by #16

Comments

@goodguyry
Copy link
Owner

I noticed the Popup component does not update tabindex on the target's interactive children until state is updated. This should be done in init.

// init()
tabIndexDeny(this.interactiveChildElements);
@goodguyry goodguyry mentioned this issue Dec 11, 2019
Merged
goodguyry added a commit that referenced this issue Dec 11, 2019
@goodguyry
Merge pull request #16 from /issues/15-popup-init-tabindex
aa23cf8 
Popup: Corrects initial tabindex for Popup interactiveChildElements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Popup: Corrects initial tabindex for Popup interactiveChildElements goodguyry/AriaComponents
1 participant
@goodguyry