Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to delete GCS objects #268

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Conversation

rgayon
Copy link
Collaborator

@rgayon rgayon commented Oct 26, 2020

No testing as it's basically just an API call. Let me know if there is something I could Mock and get a meaningful test

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #268 into master will increase coverage by 2.35%.
The diff coverage is 70.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   65.39%   67.74%   +2.35%     
==========================================
  Files          14       29      +15     
  Lines         968     2037    +1069     
==========================================
+ Hits          633     1380     +747     
- Misses        335      657     +322     
Flag Coverage Δ
#nosetests 67.74% <70.27%> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cloudforensics/providers/azure/internal/network.py 24.52% <24.52%> (ø)
libcloudforensics/providers/aws/internal/kms.py 40.00% <40.00%> (ø)
libcloudforensics/providers/gcp/forensics.py 54.54% <48.00%> (-10.46%) ⬇️
libcloudforensics/providers/aws/forensics.py 56.16% <53.06%> (-13.61%) ⬇️
...cs/providers/gcp/internal/compute_base_resource.py 37.33% <54.28%> (+0.82%) ⬆️
libcloudforensics/providers/aws/internal/log.py 73.07% <55.55%> (-4.20%) ⬇️
...ibcloudforensics/providers/gcp/internal/compute.py 56.68% <55.81%> (-5.67%) ⬇️
...bcloudforensics/providers/gcp/internal/function.py 40.54% <62.50%> (+8.28%) ⬆️
...loudforensics/providers/azure/internal/resource.py 65.38% <65.38%> (ø)
...ibcloudforensics/providers/gcp/internal/project.py 61.90% <66.66%> (-3.81%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b197f2a...50b828b. Read the comment docs.

@tomchop tomchop merged commit efc65b5 into google:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants