New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistFilter is not reentrant #1030

Open

rcbeuker opened this issue Jul 20, 2016 · 0 comments

rcbeuker commented Jul 20, 2016

Issue #597 ('Persist Extension: UnitOfWork.begin() throws IllegalStateException when called multiple times') already mentioned that PersistFilter is not reentrant;

From my Google App Engine application:

Request comes in
- FilterChain starts
  - PersistFilter starts a unit of work
    - continues FilterChain
    - I need to login, redirects to login url
      - Filter Chains runs again
        
        Persist filter throws exception starting a new unit of work.

"Work already begun on this thread. Looks like you have called UnitOfWork.begin() twice without a balancing call to end() in between."

The issue is closed, but the PersistFilter (Guice 4.1.0) is still not reentrant ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment